Remove legacy HTTP method wrappers from ApiClient - #216
Open
cx-happy-yang wants to merge 1 commit into
Open
Conversation
head_request, get_request, post_request, put_request, patch_request, and delete_request were thin wrappers around call_api with no remaining callers — all SDK modules have been migrated to call_api directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Great job! No new security vulnerabilities introduced in this pull request |
cx-happy-yang
added
the
workflows-approved
cx-james-bostock
approved these changes
Aug 13, 2026
cx-james-bostock
left a comment
cx-james-bostock
left a comment
Contributor
There was a problem hiding this comment.
Hi @cx-happy-yang,
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
head_request,get_request,post_request,put_request,patch_request, anddelete_requestfromApiClientcall_apiwith no remaining callers — the entire SDK (CxOne, CxRestAPISDK, CxScaApiSDK, CxAccessControl, CxReporting, CxODataApiSDK) has been fully migrated tocall_apigrepthat no code in the SDK, tests, or examples references these methodsTest plan
\.get_request\|\.post_request\|\.put_request\|\.patch_request\|\.delete_request\|\.head_requestto confirm zero remaining usages🤖 Generated with Claude Code