fix: do not fail LOGIN command when receiving a NO response for another request - #142
Open
link2xt wants to merge 1 commit into
Open
fix: do not fail LOGIN command when receiving a NO response for another request#142link2xt wants to merge 1 commit into
link2xt wants to merge 1 commit into
Conversation
…er request Normally the response should have been read by the time login command is sent, so this should not happen. This can still happen if the future reading the response was dropped or if the server is violating the standard and e.g. duplicates responses.
Contributor
Author
|
I have extracted it from #141 for easier review. Best reviewed with "hide whitespace", it is basically a one-line change. Consuming the response not intended for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally the response should have been read by the time login command is sent, so this should not happen. This can still happen if the future reading the response was dropped or if the server is violating the standard and e.g. duplicates responses.