Conversation
Guard DOM size and position helpers against a null canvas and cancel pending delayed resizes on destroy so a late update after teardown does not throw. Co-authored-by: Bennett Payoyo <Yahiro025@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A pending debounced
_doResizecan callupdate()afterdestroy()has already setchart.canvastonull. That rebound responsive events, hit_resize, andgetComputedStylethrew readingelement.ownerDocumentonnull.This makes DOM size/position helpers return safe defaults when the element is missing, cancels the pending delayed resize on
destroy(), and no-opsupdate/_resize/ responsive rebinding once the canvas/context is gone.Fixes #12312. Prior art: #11809 (same failure; closed without merge — still present on 4.5.1 / master).
Types of changes
Checklist
helpers.dom,core.controller,platform.basic)AI assistance
Implementation assisted by an AI coding agent; human-reviewed before opening.