CFE-3105: Made format collect data container - #6223
Open
victormlg wants to merge 1 commit into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| WriterWrite(w, " }"); | ||
|
|
||
| BufferAppendF(buf, format_rewrite, StringWriterData(w)); |
victormlg
force-pushed
the
make_format_collecting
branch
from
July 9, 2026 10:31
bf0432b to
9667796
Compare
victormlg
force-pushed
the
make_format_collecting
branch
8 times, most recently
from
July 10, 2026 13:35
3a40ef1 to
10d94b8
Compare
Ticket: CFE-3105 Changelog: Title Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
make_format_collecting
branch
2 times, most recently
from
August 4, 2026 09:25
4374730 to
34a6da4
Compare
victormlg
marked this pull request as ready for review
August 4, 2026 09:25
larsewi
reviewed
Aug 5, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Could you perhaps use VarNameOrInlineToJson() to achieve this?
Contributor
Author
That was my initial idea, however this would break backwards compatibility because string lists are formatted differently from data containers and |
nickanderson
reviewed
Aug 5, 2026
| "key='S_123_list' value='{ \"one\", \"two\", \"\\\"three\\\"\" }'"; | ||
| "key='S_container_1' value='[null]'"; | ||
| "key='S_container_2' value='[{\"x\":123},\"yz\"]'"; | ||
| "key='S_function' value='{\"hello\":\"world\"}'"; |
Member
There was a problem hiding this comment.
Must you escape the double quotes? I see it's done there before, but is it required?
nickanderson
reviewed
Aug 5, 2026
| "array[S_container_1]" string => format("%S", mycontainer1); | ||
| "array[S_container_2]" string => format("%S", mycontainer2); | ||
| "formatted" slist => maparray("key='$(this.k)' value='$(this.v)'", "array"); | ||
| "array[S_function]" string => format("%S", parsejson('{"hello": "world"}')); |
Member
There was a problem hiding this comment.
I think we should cover a json string directly to illustrate the behavior
"array[S_function]" string => format("%S", '{"hello": "world"}');
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.