perf monitoring for CBT runs - #362
Open
harriscr wants to merge 1 commit into
Open
Conversation
Fixes for perf and blktrace monitoring to align it with the new class structures in monitoring. Helped by IBM Bob 2.0.1 Signed-off-by: Chris Harris <harriscr@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code to provide monitoring using the perf tool of CBT runs already exists in the codebase. It was only set up to monitor OSDs and had some requirements that meant it would only run on clusters that used vstart.
#357 split the top monitoring, which was in the same format, into 2 separate classes: One for generic top monitoring, and one specifically for OSDs using vstart (so as not to break the existing behaviour). We can apply the same division of responsibility to perf monitoring.
This also adds checking to monitoring, so that if a monitoring tool requested in the yaml is not installed then CBT will exit with an error. The exception is collectl, which has a default set of options. If collectl is not inslaeed then a warning os written and the CBT run will continue.
Additional unit tests were added for the new code where appropriate.
This has been tested by running on a local system:
and
Helped by IBM Bob 2.0.1