Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux legs of release.yml hang for the full 20m CI timeout because test_empty_enter_freeze.nim forks a child via newTtySession("/tmp/3code_tty_stub") but never builds that binary. In CI the binary is absent, execv fails, the child quit 127s with no output, and the PTY harness expect() never finds its prompt.
Fix: copy the ensureStubBinary() proc from the sibling test_tty_functional.nim, which compiles a fresh per-pid stub binary into a temp dir, and use its result as the first arg to newTtySession instead of the hardcoded path.