feat(OutputField): add truncate prop for overflowing values - #1422
Open
omarelkashef wants to merge 1 commit into
Open
feat(OutputField): add truncate prop for overflowing values#1422omarelkashef wants to merge 1 commit into
omarelkashef wants to merge 1 commit into
Conversation
edlerd
reviewed
Sep 8, 2026
| id={id} | ||
| title={truncate ? value : undefined} | ||
| className={classNames("mono-font", "u-sv2", { | ||
| "output-field-truncate": truncate, |
Contributor
There was a problem hiding this comment.
Suggested change
| "output-field-truncate": truncate, | |
| "u-truncate": truncate, |
Can we use the existing helper from vanilla?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
truncateprop toOutputField.<output>element when enabled.titleattribute when truncation is enabled.Truncateexample and test coverage for the class and title attribute.<output>a bounded block box, allowingtext-overflow: ellipsisto apply.QA
Pinging @canonical/react-library-maintainers for a review.
Storybook
To see rendered examples of all react-components, run:
Open the
OutputFieldTruncatestory and verify a long value is displayed on one line, clipped with an ellipsis when constrained, and exposes the complete value in its native title tooltip.QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
OutputFieldwith a longvalueandtruncate.truncateand verify its existing display behavior is unchanged.Percy steps
OutputFieldTruncateStorybook story is expected to display a single-line, ellipsized long value.