json as string in JS bundle

[retyui]

Webpack wraps JSON objects inside JSON.parse('...') strings primarily for JavaScript parsing performance and memory optimization. Does it make to apply this V8 optimisation from webpack for Hermes engine (especially for apps with huge json locales)

https://github.com/webpack/webpack/blob/69adee615b758639f3499d54c0b1d62f8328c6f2/lib/json/JsonGenerator.js#L230-L237

[retyui]

Tested perf. and memory usage on React Native 0.88.x with flashlight (Samsung S10)

// JSON
require('./huge.json'); // 4mb

// JSON.parse('str')
require('./huge.js'); // File `module.exports = JSON.parse('<json as string>');` 

I thunk we need to turn off this optimisation to improve CPU/Memory usage

---

To test

flashlight test --bundleId "com.rn88"\
  --testCommand "adb shell monkey -p com.rn88 -c android.intent.category.LAUNCHER 1"\
  --duration 1000\
  --iterationCount 20\
  --resultsTitle "require('huge.json')"\
  --resultsFilePath "before.json"


flashlight report before.json after.json