feat(theme): add semantic container color prop to Surface - #5121
Open
hristototov wants to merge 1 commit into
Open
hristototov wants to merge 1 commit into
hristototov wants to merge 1 commit into
Conversation
hristototov
requested review from
JKobrynski,
adrcotfas and
satya164
and removed request for
JKobrynski and
satya164
September 14, 2026 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Surfacederives its background from the numericelevationprop, so a component cannot express "this container issurfaceContainerLow, and elevation only controls the shadow" without passing a raw color. This adds a first-class semantic API for it:containerprop onSurfaceaccepting a surface-family color role (surface,surfaceDim,surfaceBright,surfaceVariant,surfaceContainerLowest-Highest,inverseSurface), resolved from the theme. Precedence:backgroundColor>container> elevation-derived color.containeris set,elevationonly affects the shadow. Animated elevation no longer interpolates the background.Menu(surfaceContainer, per MD3 spec) andBanner(surfaceContainerLow) migrated onto it. Pixel-identical at their default elevations sinceelevation.level1-5map to the same tones. Consumers using non-default elevations now get only a shadow change (noted in the migration guide).SurfaceRoletype.Related issue
Fixes #5119.
Screenshots / Videos
light-mode.mov
dark-mode.mov
Test plan
yarn typecheck,yarn lint,yarn test— all green (55 suites, 693 tests; no snapshot diffs, confirming the Menu/Banner migrations are visually unchanged).