-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Card MD3 Expressive improvements #5116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pawelkata
wants to merge
11
commits into
callstack:main
Choose a base branch
from
pawelkata:expressive-card
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a681e7c
refactor(card): make layout helpers parent-independent
f20883e
feat(card)!: introduce slot-first filled card
9362353
feat(card): add Material variant token contract
4e37e95
feat(card): modernize responsive cover media
6386828
feat(card)!: expose one actionable target
84189cf
feat(card): add actionable state feedback
0e4f79c
feat(card): complete state and motion behavior
335a05d
fix(card): fix worklet related complaints
da09098
feat(card): add expressive example gallery
dd5916b
docs(card): publish v6 contract and migration
a2f4215
fix(docs): correct card migration examples
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { describe, expect, it } from '@jest/globals'; | ||
| import path from 'node:path'; | ||
|
|
||
| import { createComponentParser } from '../parser'; | ||
|
|
||
| describe('component docs parser', () => { | ||
| it('documents every branch of the Card public prop unions', () => { | ||
| const repositoryRoot = process.cwd(); | ||
| const parse = createComponentParser( | ||
| path.join(repositoryRoot, 'tsconfig.source.json') | ||
| ); | ||
| const { props: documentedProps } = parse( | ||
| path.join(repositoryRoot, 'src', 'components'), | ||
| { source: 'Card/Card' } | ||
| ); | ||
| const props = new Map(documentedProps.map((prop) => [prop.name, prop])); | ||
|
|
||
| expect(props.get('variant')?.type).toContain('"filled"'); | ||
| expect(props.get('variant')?.type).toContain('"elevated"'); | ||
| expect(props.get('variant')?.type).toContain('"outlined"'); | ||
| expect(props.get('elevation')?.type).toContain('Elevation'); | ||
| expect(props.get('header')?.type).toBe('React.ReactNode'); | ||
| expect(props.get('title')?.type).toBe('React.ReactNode'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes prop types on every component page. Have you checked the others?