chore: stop tracking .agent-device and keep the replay test from writing into the repo - #2722
Merged
Merged
Conversation
…ing into the repo
Size Report
Startup median (7 runs, lower is better):
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agent-device/test-artifacts/has been tracked since #2672. One unit test,session-replay-maestro-remote-evalscript.test.ts, runs the realreplay testhandler with noartifactsDir, so every local run writes two suites of artifacts into the repo root with fresh temp paths and timings. PRs keep committing that churn by accident (#2717, #2686, and #2690 before its rebase).artifactsDirunder its own temp root, so it writes nothing into the checkout./.agent-device/is ignored. It is also where the CLI puts per-project output (test artifacts, metro and tunnel logs), so nothing there belongs in git.3 files changed, plus the 16 deleted artifacts.
Validation
pnpm check:affected --runpasses at this head (full 59-check set; the.gitignorechange fails open to the full set)..agent-device/in the checkout. With it, the directory stays absent and all 4 tests pass.