docs(commands): note that timing-based apps read a fast --count 2 as a double-click - #2721
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2716. The macOS
pressdocs say--countposts that many independent clicks. The live run on #2716 showed that Finder still opens an item onpress --count 2at the default 120 ms interval, because Finder detects a double-click by timing, not by the click state the events carry. The docs now say so and name the fix: pass an--interval-mslonger than the system double-click time.One file touched:
website/docs/docs/commands.md.Validation
pnpm check:affected --runpasses at c4c5b68.press --count 2 --interval-ms 700kept the row selected; the default interval opened the folder).