fix(ble): ignore packets on a disposed gateway and drop malformed fragments - #5
Open
sethforprivacy wants to merge 2 commits into
Open
sethforprivacy wants to merge 2 commits into
sethforprivacy wants to merge 2 commits into
Conversation
…gments
After a link drop and reconnect a stale or truncated notification could
reach the gateway; the CRC validator then failed with a bare
StateError ("Not enough bytes to read") that surfaced as an app error.
Ignore packets once the gateway is disposed, and drop packets that cannot
be decoded (resetting the partial reassembly) instead of failing the
pending request. Device-reported THP errors still propagate.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The base picked up the same disposed-gateway / malformed-packet handling in trezor_gatt_gateway.dart; the only difference was this branch's explanatory comments, so they are kept. Brings in the trezor_client.dart safeguards. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA hit
Bad state: Not enough bytes to readfromCrcValidator.onTransformafter a Trezor Safe 7 timed out, the user started the key-image sync, and the device auto-reconnected: a stale/truncated BLE notification reached the gateway and the bare StateError surfaced as an app error.TrezorException) still propagate.Based on 0277176 (the commit Cake Wallet pins); Cake pins this branch in cake-tech/cake_wallet#3631.
🤖 Generated with Claude Code