Fix exception safety violation in AbiBuffer::advance#1649
Merged
alexcrichton merged 2 commits intoJul 6, 2026
Conversation
alexcrichton
reviewed
Jul 6, 2026
| let (mut ptr, len) = self.abi_ptr_and_len(); | ||
| assert!(amt <= len); | ||
| for _ in 0..amt { | ||
| // Update self.cursor incrementally for exception safety |
Member
There was a problem hiding this comment.
Could this expand on what it means by "exception safety"? For example something along the lines of handling the case where dealloc_lists panics we've at least flagged the rest of the buffer as not being advanced but this particular element won't be handled again.
alexcrichton
approved these changes
Jul 6, 2026
Merged
via the queue into
bytecodealliance:main
with commit Jul 6, 2026
1ccc7c7
29 of 58 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1646