build(deps): bump setuptools from 80.9.0 to 83.0.0 - #126
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
The Python 3.9 branch of this lock update breaks a declared development tool; the inline comment includes the reproduction and compatible resolution.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 8171, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. To let it approve, grant L2 approval by mentioning @buildsworth-bk (see L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only with an L2 grant; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
| [package.optional-dependencies] | ||
| dev = [ | ||
| { name = "check-manifest" }, | ||
| { name = "check-manifest", version = "0.41", source = { registry = "https://pypi.org/simple" }, marker = "python_full_version < '3.10'" }, |
There was a problem hiding this comment.
Blocking: This downgrades check-manifest from 0.50 to 0.41 on the supported Python 3.9 path, and that version cannot run in the project's uv environment. uv run --python 3.9 --all-extras check-manifest now exits from pep517 with No module named pip; on main, the same command runs check-manifest 0.50 and performs the manifest check. Please keep check-manifest>=0.50 and fork setuptools instead (82.0.1 for Python 3.9, 83.0.0 for >=3.10).
There was a problem hiding this comment.
Still open — the refreshed lockfile continues to select check-manifest 0.41 on Python 3.9, and the command still exits from pep517 because the uv environment has no pip.
Bumps [setuptools](https://github.com/pypa/setuptools) from 80.9.0 to 83.0.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v80.9.0...v83.0.0) --- updated-dependencies: - dependency-name: setuptools dependency-version: 83.0.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
208e92f to
e8f828f
Compare
There was a problem hiding this comment.
The existing Python 3.9 check-manifest concern remains open on this refresh; I reproduced the same failure against the current commit. I found no new issues in the lockfile update.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 12898, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
Bumps setuptools from 80.9.0 to 83.0.0.
Changelog
Sourced from setuptools's changelog.
... (truncated)
Commits
6519f72Bump version: 82.0.1 → 83.0.0d1151b1Merge pull request #5250 from pypa/feature/distutils-d7633fbeda2df31eCapture removal of dry_run parameter in changelog.00144dcMoved newsfragment to the release where it occurred.a4a5a2bAdd news fragment.77470c2Merge https://github.com/pypa/distutils into feature/distutils-d7633fbed3c43897Merge pull request #5247 from pypa/copilot/fix-pypy-version-issuebb6ea66Bump PyPy from 3.10 to 3.11 in CI workflowa2bc3acFix broken intersphinx reference to build's installation docs2d6a739Use stacked parametrize decorators instead of itertools.product