Reduce memory use of digital signature check - #318
Open
Ghesselink wants to merge 1 commit into
Open
Conversation
The check loaded and stripped the whole file per character (~10x file size in RAM) before looking for a signature. Now a chunked scan for the SIGNATURE; marker exits early when there is none, and stripping uses bytes.translate. Peak RSS on a 125 MB model drops from 1212 MB to 37 MB.
Contributor
|
keep as-is. Once merged and deployed to DEV we can pull it in with the next change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also to preview @civilx64 ?