perf: cache SDK version for span origin context - #782
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoSep 19, 2026
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
Conversation
Avoid repeated synchronous package metadata scans while creating spans; the installed SDK version is immutable for the process lifetime. Co-authored-by: Cursor <cursoragent@cursor.com>
ekeith (evanmkeith)
requested review from
Stephen Belanger (Qard)
and removed request for
Stephen Belanger (Qard)
September 18, 2026 23:18
Abhijeet Prasad (AbhiPrasad)
approved these changes
Sep 19, 2026
Abhijeet Prasad (AbhiPrasad)
enabled auto-merge (squash)
September 19, 2026 00:00
Abhijeet Prasad (AbhiPrasad)
merged commit Sep 19, 2026
c484573
into
braintrustdata:main
83 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cache installed Braintrust SDK version for the lifetime of the process
add regression test proving repeated span-origin merges resolve package metadata only once
why:
merge_span_origin_context()runs for every span, but currently resolves the installed Braintrust version throughimportlib.metadataeach time. That triggers synchronousos.stat()calls. We observed this with AIOCOP, an asyncio event-loop monitoring tool: these synchronous calls appeared in stalls lasting 2.45–3.18 seconds under load.Since the installed version cannot change during a process's lifetime, caching it removes repeated blocking I/O while preserving behavior.
Example stack trace captured in SigNoz:
timing:
Local timing on macOS with Python 3.12 using
python -m timeit:importlib.metadata.version("braintrust"): 113 µs per call_sdk_version(): 10.3 ns per call