Pins VTK<9.7.0 - #471
Merged
Merged
Conversation
Member
Author
|
Test failures are related to seung-lab/osteoid#12 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 89.64% 89.64%
=======================================
Files 27 27
Lines 1313 1313
=======================================
Hits 1177 1177
Misses 136 136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alessandrofelder
approved these changes
Sep 3, 2026
alessandrofelder
left a comment
alessandrofelder
left a comment
Member
There was a problem hiding this comment.
Thanks @IgorTatarnikov !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
The ruler tests were failing with the new version of VTK.
What does this PR do?
Pins vtk<9.7.0 while the root cause is identified and fixed.
References
#470
How has this PR been tested?
Tests pass in a fresh environment with
vtk<9.7.0Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: