[PM-38272] fix: handle null or empty permissions in OrganizationUserResponseModel

[JaredScar]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38272

📔 Objective

Stops sending back empty permissions model for non-custom users

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR stops emitting an all-false Permissions object for organization members with no stored permissions: both OrganizationUserResponseModel constructors now use the documented GetPermissions() accessor (which returns null for null/whitespace JSON) and the property is annotated with [JsonIgnore(WhenWritingNull)] so it is omitted from the response. The change is confined to the admin console response model; runtime authorization paths (OrganizationUserValidationService, UserDecryptionOptionsBuilder, ProfileOrganizationResponseModel) are untouched. Custom-type members always have permissions persisted at invite time (OrganizationService.cs:587, CreateOrganizationUserExtensions.cs:29), so the omission only affects non-Custom members, matching the stated objective.

Code Review Details

No blocking findings. The previously raised duplication of the null guard was addressed by switching to GetPermissions().

Note: test/Api.Test/AdminConsole/Models/Response/OrganizationUserResponseModelTests.cs already constructs org users with Permissions = null but does not assert result.Permissions is null, so the new behavior remains unasserted.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.22%. Comparing base (5358a2f) to head (939c1a2).

Additional details and impacted files

@@            Coverage Diff            @@
##           main    #8207       +/-   ##
=========================================
+ Coverage      0   63.22%   +63.22%     
=========================================
  Files         0     2381     +2381     
  Lines         0   103757   +103757     
  Branches      0     9385     +9385     
=========================================
+ Hits          0    65604    +65604     
- Misses        0    35924    +35924     
- Partials      0     2229     +2229     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.