Skip to content

Auth/ PM-41503 & PM-41533 - Add openOrgInvite param to SDK registration finish call - #7255

Closed
JaredSnider-Bitwarden wants to merge 1 commit into
mainfrom
auth/pm-41503-and-pm-41533/registration-add-open-org-invite-support
Closed

Auth/ PM-41503 & PM-41533 - Add openOrgInvite param to SDK registration finish call#7255
JaredSnider-Bitwarden wants to merge 1 commit into
mainfrom
auth/pm-41503-and-pm-41533/registration-add-open-org-invite-support

Conversation

@JaredSnider-Bitwarden

@JaredSnider-Bitwarden JaredSnider-Bitwarden commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-41503
https://bitwarden.atlassian.net/browse/PM-41533

Server PR: bitwarden/server#8159
Server SDK Bindings Update PR: bitwarden/sdk-internal#1372
SDK PR which wires up breaking changes: bitwarden/sdk-internal#1363

📔 Objective

The SDK's UserMasterPasswordRegistrationRequest gains a new openOrgInvite field (Option<RegistrationFinishOpenOrgInviteData>) to support finishing registration via an open organization invite link once bitwarden/sdk-internal#1363 merges. Android does not use open-org-invite (that flow is web-only), so this passes null at the production call site and the two matching test expectations to satisfy the new required constructor parameter.

📸 Screenshots

n/a

@JaredSnider-Bitwarden
PM-41503 / PM-41533 - Add openOrgInvite param to SDK register call
e6add26 
The SDK's `UserMasterPasswordRegistrationRequest` gains a new
`openOrgInvite` field (`Option<RegistrationFinishOpenOrgInviteData>`)
to support finishing registration via an open organization invite
link. Android does not use open-org-invite (that flow is web-only),
so this passes `null` at the production call site and the two
matching test expectations to satisfy the new required constructor
parameter.
@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label Aug 10, 2026
@JaredSnider-Bitwarden JaredSnider-Bitwarden added the ai-review Request a Claude code review label Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds the new openOrgInvite parameter to the SDK UserMasterPasswordRegistrationRequest construction in AuthSdkSourceImpl.postKeysForUserPasswordRegistration, passing null since the open-org-invite flow is web-only. The two corresponding MockK expectations in AuthSdkSourceTest were updated to match. The null value is consistent with the other web-only registration parameters already passed as null at this call site (orgInviteToken, organizationUserId, providerInviteToken, etc.), so no behavior change is introduced for Android. No security, correctness, or breaking-change concerns were identified in the changed code.

Code Review Details

No blocking findings in the changed code.

Merge readiness note (not a code finding): gradle/libs.versions.toml still pins bitwardenSdk = "3.0.0-8157-eb825d59" and is not modified by this PR, while the description notes the SDK change wiring up this breaking parameter (sdk-internal#1363) is unmerged. All Test CI jobs are currently failing. This PR presumably needs the SDK version bump before it can compile and merge — worth confirming before merging.

@JaredSnider-Bitwarden JaredSnider-Bitwarden mentioned this pull request Aug 10, 2026
Merged
JaredSnider-Bitwarden added a commit to bitwarden/sdk-internal that referenced this pull request Aug 11, 2026
@JaredSnider-Bitwarden
Auth / PM-41503 & PM-41533 - Registration - Add open-org-invite reque…
519a1a6 
…st model to password registration finish (#1363)

## 🎟️ Tracking
<!-- Paste the link to the Jira or GitHub issue or otherwise describe /
point to where this change is coming from. -->
https://bitwarden.atlassian.net/browse/PM-41503
https://bitwarden.atlassian.net/browse/PM-41533

Server PR: bitwarden/server#8159
Server SDK Bindings Update PR:
#1372

PRs that will merge shortly after that depend on this change:
bitwarden/clients#22333
bitwarden/ios#2953
bitwarden/android#7255

## 📔 Objective

<!-- Describe what the purpose of this PR is, for example what bug
you're fixing or new feature you're adding. -->
Adds an optional `open_org_invite` field to the normal master-password
open registration finish flow so the register-finish payload can carry
the open-organization-invite data. Introduces a purpose-built
`RegistrationFinishOpenOrgInviteData` request type and a new
`RegistrationError::InvalidInput` variant for UUID parse failures.
@JaredSnider-Bitwarden

JaredSnider-Bitwarden commented Aug 11, 2026

Copy link
Copy Markdown
Author

Closed in favor of #7254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-livefront david-livefront Awaiting requested review from david-livefront david-livefront will be requested when the pull request is marked ready for review david-livefront is a code owner

Assignees

No one assigned

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JaredSnider-Bitwarden