bip379 to bip390: Update to Specification type - #2292
Open
danielabrozzoni wants to merge 11 commits into
Open
danielabrozzoni wants to merge 11 commits into
danielabrozzoni wants to merge 11 commits into
Conversation
jonatack
added
the
Metadata Update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2251 (comment): BIP3 changed the criteria for BIP types; under new criteria, the descriptor BIPs belong to the "Specification" type. This PR updates all the BIPs from bip379 to bip390, excluding bip388, since it already has the right type.
Note that bip380 to bip387 are already in the "Deployed" status, and BIP3 specifies that modifications beyond minor amendments should be avoided. I think it's still okay to change the type of these, but wanted to flag in case people think it's not minor, and should be avoided.