Skip to content

feat: add hold as a trigger event modifier - #3438

Closed
81reap wants to merge 1 commit into
bigskysoftware:masterfrom
81reap:master
Closed

81reap wants to merge 1 commit into
bigskysoftware:masterfrom
81reap:master

Conversation

@81reap

@81reap 81reap commented Sep 23, 2025

Copy link
Copy Markdown

Description

Please describe what changes you made, and why you feel they are necessary. Make sure to include
code examples, where applicable.

adds hold as a trigger event

Corresponding issue:

None, I wanted to create a hold-to-click interaction and realized how common of a pattern it is, so I decided to take a stab at upstreaming it into HTMX

Testing

Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.

I tried to test as many edge cases as I could, if any reviewer comes up with more, I can try adding those too. :)

Checklist

  • [y] I have read the contribution guidelines
  • [i think so] I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • [n] This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • [y] I ran the test suite locally (npm run test) and verified that it succeeded

@81reap
81reap marked this pull request as ready for review September 23, 2025 06:07
@81reap

81reap commented Sep 23, 2025

Copy link
Copy Markdown
Author

okay now its ready for review. I had open OpenCode the PR, but I accidentally had added the dist/* files. Thats been fixed now

@81reap

81reap commented Sep 23, 2025

Copy link
Copy Markdown
Author

also I wasn't sure if I was targeting the correct branch because this has HTMX changes and website changes

@81reap

81reap commented Sep 24, 2025

Copy link
Copy Markdown
Author

recreated PR on correct branch :: #3442

@81reap 81reap closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant