fix(fleet): no-issue: creating a machine with no optional fields - #575
Merged
Merged
Conversation
|
🦸 Review Hero Summary (round 1) Local fix prompt (copy to your coding agent) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fleet/machines/createreturned 500 and created the machine anyway when every optional field was omitted: it inserts, then applies the rest of the form as an edit, and diesel refuses to build an empty update.Machine::updatetakes diesel's.optional_empty_changeset(), which also fixesmachines/updatesent with onlymachine_id.Application::updatehad the same case handled by hand, swallowing everyQueryBuilderErrorrather than just the empty one. Now the same call, so it is one idiom and stricter.Guarding in
createinstead would mean hand-enumeratingMachineUpdate's fields away from the struct.Run Review Hero