Support Ruby 3.4 and 4.0 for incremental EB upgrade; enable deprecation warnings - #562
Draft
superconductor-for-github[bot] wants to merge 1 commit into
Draft
Support Ruby 3.4 and 4.0 for incremental EB upgrade; enable deprecation warnings#562superconductor-for-github[bot] wants to merge 1 commit into
superconductor-for-github[bot] wants to merge 1 commit into
Conversation
Allows an incremental Elastic Beanstalk rollout: the Gemfile now accepts >= 3.4, < 4.1 so the app runs on both the EB "Ruby 3.4 on AL2023" platform (ruby 3.4.10, matching the previous lockfile) and Ruby 4.0.6, the latest 4.0.x and what the "Ruby 4.0 on AL2023" platform ships. - Local tooling (mise, Dockerfile, devcontainer) moves to Ruby 4.0.6 - RSpec CI runs a 3.4 + 4.0 matrix; other workflows follow .tool-versions - buildspec stays on ruby 3.4 in lockstep with the EB platform; bump to 4.0 together with the platform upgrade - Bundler pinned at 4.0.19 (lockfile + EB prebuild hook) — Bundler 2.5.6 emits constant-redefinition warnings under Ruby 4.0's RubyGems - Ruby-level deprecation warnings (Warning[:deprecated]) are enabled globally in boot.rb instead of only dev/test, and production now logs Rails deprecations instead of silencing them Verified on both 3.4.10 and 4.0.6: RSpec 712/712, RuboCop clean, Cucumber rack_test 24/24, Jekyll docs build. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Author
|
🔗 This pull request is linked to Superconductor implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #189.
What this does
Makes the app run on Ruby 3.4.x or 4.0.x (
Gemfile:>= 3.4, < 4.1) so the Elastic Beanstalk environments can be bumped incrementally — first to the Ruby 3.4 on AL2023 platform branch (ruby 3.4.10, exactly what the lockfile was already on), then to Ruby 4.0 on AL2023 (ruby 4.0.6, the latest 4.0.x) — and enables deprecation warnings everywhere so anything the upgrade shakes loose is visible.Local
.tool-versions→ruby 4.0(currently resolves to 4.0.6);misedocs updatedDockerfileand.devcontainer/Dockerfile→4.0.6(both image tags verified to exist)TargetRubyVersion→ 3.4 (the new floor)CI
.tool-versions→ 4.03.4→4.0(Jekyll build verified under 4.0.6)buildspec.yml→ruby: 3.4, staying in lockstep with the EB platform; CodeBuild AL2023 images supportruby: 4.0for the next hopElastic Beanstalk
buildspec.ymltoruby: 4.0in the same change (comments inbuildspec.ymldocument this).BUNDLED WITH). Bundler 2.5.6 works on Ruby 4.0 but spews constant-redefinition warnings against its RubyGems 4.x; 4.0.19 is clean on both rubies.Deprecation warnings
Warning[:deprecated] = truemoved from the dev/test env files toconfig/boot.rb, so Ruby-level deprecations surface in every environment and process (server, console, rake, EB)report_deprecations = true,deprecation = :log) instead of silencing themVerification
Full suite run locally on both rubies:
rack_test)(JavaScript cucumber scenarios couldn't run in the sandbox — chromedriver can't start there; they're exercised in CI.)
App boots warning-free on both rubies, and
Warning[:deprecated]is confirmedtrueat runtime with Rails deprecation behavior:log.🤖 Generated with Claude Code