test: cover track_vm_host and name the NetBox field it fills - #561
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows your answer on #516.
The option does exactly what was asked, but it had no test, so I added one: it runs both captures and compares the VM's device against what pyVmomi reports for
vm.runtime.host, checks the field stays unset by default, that a VM whose host is filtered out still syncs, and that the device follows the VM to another host.The reason it was not found is probably wording - neither the option name nor its text mentions "Host Device", which is what NetBox calls the field. Reworded both the option description and
settings-example.inito say it, and to mention the NetBox 3.3 requirement the code already enforces. Leaving #516 open for @tikondrus to confirm.