Release 1.0.0 - #4
Open
davidsteeb wants to merge 10 commits into
Open
davidsteeb wants to merge 10 commits into
davidsteeb wants to merge 10 commits into
Conversation
davidsteeb
force-pushed
the
task/release-1.0.0
branch
from
September 17, 2026 13:39
09c40d6 to
b634f73
Compare
None of these stand on their own, so they come in one commit: - CHANGELOG.md and SECURITY.md - .gitattributes, so the package contains the extension and not its tests - .gitignore, which the repository did not have - a phpunit configuration; without one the existing unit test could not be run - GitHub Actions running those tests against TYPO3 v13 and v14 - the TER publish workflow - credits in the README, and authors in composer.json
It described the extension as it stood at the initial release. Rewritten in the order the features build on each other — pixel pool, authors, text extraction, reporting — with the checks and the multi-page case after them, and saying what stays manual without Pro rather than implying it is impossible.
The README said v14 only. composer.json requires "^13 || ^14", ext_emconf.php declares 13.4.0-14.99.99, and the tests run against both. Adds a pointer to the changelog.
davidsteeb
force-pushed
the
task/release-1.0.0
branch
from
September 17, 2026 13:42
b634f73 to
569a6c1
Compare
Both places that mention Pro asked the reader to get in touch instead of pointing anywhere. They now link to the product page, in the introduction and in the section itself.
Same two parameters as the credits block, for the same reason: the TER, GitHub and the aggregators pass on no usable referrer, so without them this traffic cannot be told apart from a bookmark. The two links are not distinguished from each other. A third parameter would have to be kept in step with where the links sit, and a parameter nobody maintains is worse than none.
TYPO3 14.3 reads ext_emconf.php only when composer.json does not carry this metadata itself, and reports that on every boot. The version was already there; Package.providesPackages was not. An empty object is the honest value, since the extension provides no further packages. ext_emconf.php stays: the deprecation notice says TER and tailor may still need it, and that is how this extension is published.
Both the README and SECURITY.md left the question open with a sentence about local data protection law, which is the least useful thing to say: an operator reading it has no reason not to put the pixel behind a consent banner, and a pixel that renders after someone clicks "accept" counts a fraction of what it should. VG Wort has published a position — no personal data processed, so no GDPR, and in their reading no consent requirement under § 25 (1) TDDDG — and a passage to put in a privacy policy. Quoted as theirs, because it is theirs; the decision still belongs to whoever answers for privacy on the site. The processor and the purpose of the session cookie are named as well. Both are what someone filling in a processor list actually needs.
The edition was already named, which says which text is quoted. What was missing is when anyone last checked that it is still the current one — the two answer different questions, and only the second goes stale on its own. Same wording as the reporting thresholds carry, so a reader meets one convention rather than two.
davidsteeb
force-pushed
the
task/release-1.0.0
branch
from
September 17, 2026 19:32
3ea7a5a to
f735dc9
Compare
The parameter belongs to VG Wort Pro: the middleware that strips the extraction markers and the token that authorises them both live there, and this package references it nowhere else. The exception that keeps it out of the cache hash belongs next to them, and that is where it is now. Installing both extensions keeps working - Pro declares the exception itself from the version that removes it here. Update the two together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the first stable release, plus the repository housekeeping that should come with it.
Why 1.0
Nothing about how the extension works changes. What changes is the version promise: the TCA field
tx_vgwort_pixel, the site setb13/vgwortwith its settings, and theVgwortTrackingpartial are a public interface that stays stable within 1.x. That surface has not changed since the initial release.It also matters for anything depending on this package. Under Composer,
^0.1resolves as>=0.1.0 <0.2.0, so every new minor of a 0.x package is a breaking change for its consumers.^1.0is an ordinary compatibility window.What is in here
CHANGELOG.mdandSECURITY.md.gitattributes, so the package contains the extension and not its tests — 35 entries instead of 37.gitignore, which the repository did not haveBuild/phpunit/UnitTests.xml— there was no phpunit configuration, so the existing unit test could not be run.github/workflows/tests.yml: those tests on every push and pull request, against TYPO3 v13 and v14.github/workflows/publish.yml, taken unchanged from [TASK] Add TER publish workflow #3, which this supersedesauthorsincomposer.json, and the version inext_emconf.php, which had stayed at0.1.0through three releasesTested
php -loverClasses/andTests/composer validate --strictgit archive HEAD: the package contains the extension onlyNote for merging
Please do not tag straight away — the tag triggers the TER release, and we want to coordinate that separately.