test: fix hardcoded HyperPod cluster name in Nova integ tests#6005
Open
lucasjia-aws wants to merge 1 commit into
Open
test: fix hardcoded HyperPod cluster name in Nova integ tests#6005lucasjia-aws wants to merge 1 commit into
lucasjia-aws wants to merge 1 commit into
Conversation
The GPU integ tests in us-east-1 fail with ResourceNotFound because the CPT/SFT HyperPod tests hardcode the cluster name "riv-rig" (introduced in the Nova release), which does not exist in the test account. The actual provisioned cluster is "pysdk-hp-integ-tests". Read the cluster name from the PYSDK_HYPERPOD_CLUSTER_NAME env var with a default of "pysdk-hp-integ-tests" so a future cluster rename no longer requires a code change. Applied to test_cpt_hyperpod.py, test_cpt_data_mixing_hyperpod.py, and test_sft_data_mixing_hyperpod.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GPU integ tests in us-east-1 fail with ResourceNotFound because the CPT/SFT HyperPod tests hardcode the cluster name "riv-rig" (introduced in the Nova release), which does not exist in the test account. The actual provisioned cluster is "pysdk-hp-integ-tests".
Read the cluster name from the PYSDK_HYPERPOD_CLUSTER_NAME env var with a default of "pysdk-hp-integ-tests" so a future cluster rename no longer requires a code change. Applied to test_cpt_hyperpod.py, test_cpt_data_mixing_hyperpod.py, and test_sft_data_mixing_hyperpod.py.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.