fix(askui-nodejs): only report a screenshot for the final waitUntil failure - #883
Merged
Merged
Conversation
…ailure waitUntil re-implemented its own retry loop, treating every attempt as an independent step with its own onStepBegin/onStepEnd, so a screenshot was captured and saved on every failed attempt instead of only the final one. Delegate to the existing retryStrategy-based retry mechanism instead (the same one predictCommandWithRetry already uses internally): one step, onStepRetry for intermediate failures, a single onStepEnd carrying the onFailure screenshot only for the truly final outcome. Also tags the reported instruction with a "waitUntil: " prefix so these steps are recognizable in reports. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitUntilreimplemented its own retry loop, treating every attempt as an independent step (ownonStepBegin/onStepEnd), so a screenshot was captured and saved on every failed attempt instead of only the final one.retryStrategy-based retry mechanism (the same onepredictCommandWithRetryalready uses internally): one step,onStepRetryfor intermediate failures, a singleonStepEndcarrying theonFailurescreenshot only for the truly final outcome.waitUntilare now prefixed with"waitUntil: "so these steps are recognizable in reports (e.g. Allure).Test plan
ui-control-client.spec.ts(written first, confirmed red against the old implementation, green after the fix): success on first try, success after retries, final-failure-only screenshot, instruction prefix.askui-nodejstest suite passes (npm test).npm run lint).🤖 Generated with Claude Code