feat(askui-nodejs): connect to AgentOS directly by default, add agentOsUseProxy opt-in - #882
Merged
Merged
Conversation
…OsUseProxy opt-in grpc-js honors grpc_proxy/https_proxy/http_proxy and tries to CONNECT through them, which fails behind corporate proxies that answer with redirects (e.g. 302) or auth pages. The AgentOS gRPC channel now ignores proxy environment variables by default; set the new client arg agentOsUseProxy to true to route the connection through the proxy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connecting to an AgentOS (local or remote) failed behind corporate proxies with
Failed to connect to ... through proxy ... with status 302because grpc-js honorsgrpc_proxy/https_proxy/http_proxyand tries to CONNECT through them — and HTTP proxies that answer CONNECT with redirects or auth pages cannot tunnel gRPC.grpc.enable_http_proxy: 0by default, so the connection is always established directly, regardless of proxy environment variablesagentOsUseProxy(defaultfalse): set totrueto restore proxy routing for setups where the AgentOS is only reachable through a proxyproxyAgents/HTTP inference traffic is unaffected — this only changes the gRPC device connectionTest plan
npm run build,npm run lint,npm run testall pass (52 passed, 7 skipped)🤖 Generated with Claude Code