Skip to content

feat: add cli arg and interactive prompt for bucket name - #244

Open
arsdehnel wants to merge 2 commits into
ascorbic:mainfrom
arsdehnel:allow-custom-bucket-name
Open

feat: add cli arg and interactive prompt for bucket name#244
arsdehnel wants to merge 2 commits into
ascorbic:mainfrom
arsdehnel:allow-custom-bucket-name

Conversation

@arsdehnel

@arsdehnel arsdehnel commented Sep 9, 2026

Copy link
Copy Markdown

Closes #107

In contrast to #201 I added the bucket naming to the create-pds CLI's variables here. I think the auto-naming convention of wrangler is useful but for the reasons mentioned in that PR's discussion I think this use case might not be a good one for it.

Docs

I updated a few places in the docs that reference buckets. Most notably was a change only indirectly related to my code change. There were two places that mentioned that bucket names must be globally unique. I don't believe that's the case with Cloudflare's buckets (although it definitely is the case with other cloud provider bucket implementations).

create-pds

I added an optional CLI arg for --blobs-bucket-name which effectively defaults to pds-blobs although to allow for the "should we prompt" logic I didn't use citty's default option and instead followed the pattern of projectName. I think write that to the wrangler.jsonc after copying it over from the template directory following the package.json pattern.

Tests

I added a few tests but not sure how you will feel about the basic string-matching of the assertions. Open to other ideas.

Changeset

I've never managed or contributed to a monorepo that uses that so hopefully I got that right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: allow customization of cloudflare r2 bucket name

1 participant