Skip to content

Automate setting of pnpm allowBuilds in workspace #243

Description

@arsdehnel

I'm trying to get setup with Cirrus for my "dev" handle and hit an error. It's easy enough to get by and rerun the init command but it seems like it would make more sense to just run another command for the user since the packages are installed via the init command.

> cd my-pds-folder && pnpm pds init
Lockfile is up to date, resolution step is skipped
Already up to date
[ERR_PNPM_IGNORED_BUILDS] Ignored build scripts: esbuild@0.25.12, esbuild@0.28.1, workerd@1.20260908.1

Run "pnpm approve-builds" to pick which dependencies should be allowed to run scripts.
[ERROR] Command failed with exit code 1: pnpm install

I'd be open to taking a shot at making the change but with any new codebase just want to be sure you're open to that and check on any contribution guidelines or anything. Looks like somewhere in here adding a check and pnpm-only condition:

if( pm === 'pnpm' ) {
    await runCommand(pm, ["approve-builds", "esbuild", "workerd"], targetDir, { silent: true });
}

Depending on what version of pnpm you want to have supported the check might need to consider the pnpm version as well.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions