Conversation
erak
changed the title
erak
added this pull request to stack #17018
September 16, 2026 11:10
erak
force-pushed
the
syntax-test-refactoring
branch
from
September 16, 2026 11:18
c1f4478 to
1ef57ba
Compare
erak
force-pushed
the
syntax-test-refactoring
branch
from
September 17, 2026 08:12
1ef57ba to
2554f26
Compare
erak
marked this pull request as ready for review
September 17, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of #16970.
Description
Decouples test settings from compiler invocation in the syntax test infrastructure and enables optional settings.
Details
Introduced
SyntaxTestSettingsstruct: makes settings explicit and self-contained, replacing ad-hoc member variables on SyntaxTest.Added optional setting readers to
TestCaseReader: lets callers distinguish "setting absent" from "setting present with a value", needed to detect unset vs explicitly configured options.Introduced
CompilerInputstruct: groups all compiler configuration into a single object, replacing scattered members (m_sources,m_evmVersion,m_modelCheckerSettings) to decouple test settings from how the compiler is invoked.AI Disclosure