Persist completed session results - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production findings
Session
github-pr-e2e-0826dcompleted its external-only workflow with two independently reviewed successfulgithub.readreceipts and correctly selected aptos-core PR #20446. The E2E still could not pass because the completion command terminated the model before a self-contained caller response was persisted, and the gateway report endpoint depended on a live worker Pod. The exported trace contains the correct operational evidence but the generated report contains only status and trace links.Architecture
The control server continues to own result streaming and persistence. The orchestrator only synthesizes the caller response from the original goal and accumulated role results; it gains no operation-specific knowledge or transport credentials. Normal source completion is unchanged.
Validation
rustup run 1.98.0 cargo fmt --checkrustup run 1.98.0 cargo test --workspace --all-targets(59 passed)rustup run 1.98.0 cargo buildnpm test --prefix control-server(10 passed)tests/run.shtests/mock_orchestration_e2e.shgit diff --check