Skip to content

Fix external completion outside Git worktrees - #44

Merged
areshand merged 1 commit into
mainfrom
codex/fix-external-completion-non-git
Aug 26, 2026
Merged

Fix external completion outside Git worktrees#44
areshand merged 1 commit into
mainfrom
codex/fix-external-completion-non-git

Conversation

@areshand

Copy link
Copy Markdown
Owner

Summary

  • separate source-diff completion checks from external-operation closure checks
  • keep normal source completion fail-closed on the canonical Git diff
  • allow external-only workflows to complete outside Git while retaining verifier, finding, and TODO closure checks
  • add a lifecycle regression for enforced external-only completion with a successful terminal receipt and a non-Git root

Production finding

The GitHub E2E completed four independently reviewed github.read operations through prod-mcp and found aptos-core PR #20446 with an empty submitted-review list. Final workflow completion then failed because the shared source completion checker invoked git diff from the session control working directory, which is intentionally not a Git worktree.

Validation

  • rustup run 1.98.0 cargo fmt --check
  • rustup run 1.98.0 cargo test --workspace --all-targets (59 passed)
  • rustup run 1.98.0 cargo build
  • npm test --prefix control-server (8 passed)
  • tests/run.sh
  • tests/mock_orchestration_e2e.sh
  • git diff --check

@areshand
areshand merged commit 0d7416e into main Aug 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant