Fix login overlay and password echo - #43
Merged
areshand merged 2 commits intoAug 26, 2026
Merged
Conversation
.login-shell sets display:grid, which outranks the user-agent [hidden] rule, so the login overlay stayed on screen after a successful login. Co-authored-by: Cursor <cursoragent@cursor.com>
readline.question leaves the plaintext in scrollback and shell history. Read raw keystrokes instead and require a TTY. Co-authored-by: Cursor <cursoragent@cursor.com>
yzaccc
changed the title
yzaccc
force-pushed
the
fix/login-overlay-and-password-echo
branch
from
August 26, 2026 07:17
4d35576 to
e307539
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.login-shellsetsdisplay:grid, which outranks the user-agent[hidden]rule.showConsole()setlogin.hidden = truebut the overlay stayed on screen, so a correct password looked like it did nothing. An explicit[hidden] { display:none !important; }makes the attribute authoritative.bin/hash-password.mjsechoed the password, leaving plaintext in scrollback and shell history. It now reads raw keystrokes and requires a TTY, so there is no silent fallback to an echoing prompt.Test plan
cd control-server && npm test— 8/8verifyPassword