test: Assert RequestList persists the expected request contents#2027
Merged
vdusek merged 1 commit intoJul 7, 2026
Merged
Conversation
vdusek
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three of the
RequestListpersistence tests intests/unit/request_loaders/test_request_list.pybuild a persisted value in thekey-value store and then only assert
persisted_data is not None. Each of theirdocstrings/comments claims to verify the actual persisted request set, but the
contents were never checked, so a regression that persisted the wrong URLs, an
empty list where data was expected, or a malformed structure would still pass.
This adds one content assertion per test on top of the existing null check:
test_persist_requests_key_with_sync_iterable: the persisted URLs equal thethree input URLs (docstring: "persists request data").
test_persist_requests_key_with_empty_iterator:persisted_data['requests']equals
[](comment: "empty requests were persisted").test_handle_invalid_url_with_persistence: the persisted URLs are exactly['https://valid.placeholder.com'], so the invalid URL is excluded (comment:"the valid URL was persisted and the invalid one was not").
The existing
assert persisted_data is not Nonelines are kept: they narrow thetype before the new subscripting.
No production code changes; this only strengthens existing assertions.
Issues
Testing
uv run pytest tests/unit/request_loaders/test_request_list.py -v-> 11 passed.uv run poe lint(ruff format check + ruff check) -> clean on the changed file.uv run poe type-check-> no new diagnostics from this change.value makes exactly that test fail, and reverting restores green.
Checklist