Build dual ESM/CJS output with two tsc runs - #252
Open
matejos wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #243.
The package was CommonJS only. It now ships both, selected through the
exportsmap. The public API does not change.pnpm run buildrunstsctwice, intodist/cjsanddist/esm. Each output directory gets a smallpackage.jsonthat declares its module type. That is what lets one set of.d.tsfiles serve both, so the repo root stays CommonJS.Every relative import in
srcnow carries a.jsextension, and so do the lodash deep imports. ES modules do not resolve an extensionless path, andtscemits the specifier as written. Jest maps the extension back through a newmoduleNameMapper.scripts/verify-dist.tsguards it in CI by loading both builds in a real Node.js process.The built files moved, so
mainis nowdist/cjs/node-index.js. Any consumer that deep imports@api3/commons/dist/..., or that uses thepathsoverride from the README, needs a path update. Named imports from the package root are unaffected.Tested against oev-searcher, purinta-lending and airnodehub by packing the build into each: all typecheck, build and test clean, with no source changes needed.
publintand@arethetypeswrong/cliare both green.