Conversation
TomEE serves requests through Tomcat's connectors, so the hand written HTTP server in openejb-http is unused attack surface. Removes it, the unreachable Jetty backend, the httpejbd service and OpenEJBHttpRegistry. isTextXml and reformat move to HttpUtil. RsRegistryImpl and OpenEJBHttpWsRegistry extended OpenEJBHttpRegistry and were the non-Tomcat fallbacks in RESTService and WsService; both go, so openejb-standalone and arquillian-openejb-embedded lose embedded REST/WS wiring. Everything Tomcat needs stays: listeners, the registry, request, response and session, the servlet and filter adapters, ServerServlet and the CDI listeners. The tests that drove the removed transport over a socket go with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TomEE serves requests through Tomcat's connectors, so the hand written HTTP server in
openejb-httpis unused attack surface. This removes it along with the unreachable Jetty backend, thehttpejbdservice andOpenEJBHttpRegistry, keeping everything Tomcat needs: the listeners and registry, the request/response/session types, the servlet and filter adapters,ServerServletand the CDI listeners.RsRegistryImplandOpenEJBHttpWsRegistryextendedOpenEJBHttpRegistryand were the non-Tomcat fallbacks inRESTService/WsService, so they go too —openejb-standaloneandarquillian-openejb-embeddedlose their embedded REST/WS wiring, which is accepted for a major release.The tests that drove the removed transport over a socket are removed with it; the remaining 14 pass, and all dependent modules still build.