You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PhantomJS is no longer maintained and has known incompatibilities with
modern OpenSSL (3+).
Replace it with Headless Chrome via testem's built-in browser_args support.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
2. checked out pr, ran mvn clean install in tez-ui and I saw a browser window running the tests:
@abstractdog Initially the changes related to headless present in my first commit. After that while fixing ui-tests it got overwritten. Let me fix and run locally and verify it. thanks !
maheshrajus
changed the title
TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome
[wIP] TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome
Jul 1, 2026
maheshrajus
changed the title
[wIP] TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome
TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome
Jul 2, 2026
@abstractdog I fixed your review comments and verified locally + in yetus CI env. Could you please review the PR at your convenience? Thank you !
looks good so far, I have only one concern: on a vanilla ubuntu server, when chromium wasn't installed, the build simply failed by:
Building..Built project successfully. Stored in "/home/abstractdog/apache/tez/tez-ui/src/main/webapp/tmp/class-tests_dist-NhEe6O0O.tmp".
not ok 1 Chrome - Browser "scripts/chrome-launcher.sh --headless --disable-gpu --no-sandbox --disable-dev-shm-usage --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type <url>" exited unexpectedly.
if the build process cannot take care of fetching a chrome or chromium, then a preinstalled chrome is a hard dependency of a mvn clean install command, which doesn't sound good to me
could the build process take care of the same automatically?
if the build process cannot take care of fetching a chrome or chromium, then a preinstalled chrome is a hard dependency of a mvn clean install command, which doesn't sound good to me
could the build process take care of the same automatically?
@abstractdog Thank you for the review. I have not taken care of chromium, Let me check and fix it.
@abstractdog I have addressed your review comments and tested the changes in the environments listed below. Everything is working as expected.
Please let me know if I missed anything or if I should verify this in any other environment. Thanks !
macOS with & without system chrome,
Ubuntu 22.04 – no system Chrome
Ubuntu 22.04 – system Chrome installed
Debian 12 – no system Chrome
Amazon Linux 2023 – no system Chrome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhantomJS is no longer maintained and has known incompatibilities with
modern OpenSSL (3+).
Replace it with Headless Chrome via testem's built-in browser_args support.