feat(workflow): persist is_form_view and add Form View toggle endpoints - #8125
Open
yangzhang75 wants to merge 1 commit into
Open
feat(workflow): persist is_form_view and add Form View toggle endpoints#8125yangzhang75 wants to merge 1 commit into
yangzhang75 wants to merge 1 commit into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8125 +/- ##
============================================
- Coverage 94.03% 94.03% -0.01%
- Complexity 4762 4769 +7
============================================
Files 1181 1181
Lines 47877 47899 +22
Branches 5324 5328 +4
============================================
+ Hits 45020 45040 +20
- Misses 1433 1435 +2
Partials 1424 1424
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yangzhang75
force-pushed
the
formview-pr2
branch
from
August 30, 2026 07:25
a97f44a to
f4b0160
Compare
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 547 | 0.334 | 18,444/24,605/24,605 us | 🔴 +49.6% / 🔴 +66.7% |
| 🟢 | bs=100 sw=10 sl=64 | 1,140 | 0.696 | 83,662/117,153/117,153 us | 🟢 +26.6% / 🔴 +16.0% |
| 🟢 | bs=1000 sw=10 sl=64 | 1,331 | 0.813 | 738,599/835,408/835,408 us | 🟢 +44.3% / 🟢 -20.6% |
Baseline details
Latest main 04b213d from 2026-08-29T13:05:59.195Z
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 547 tuples/sec | 705.48 tuples/sec | 842.25 tuples/sec | -22.5% | -35.1% |
| bs=10 sw=10 sl=64 | MB/s | 0.334 MB/s | 0.431 MB/s | 0.514 MB/s | -22.4% | -35.0% |
| bs=10 sw=10 sl=64 | p50 | 18,444 us | 13,866 us | 11,860 us | +33.0% | +55.5% |
| bs=10 sw=10 sl=64 | p95 | 24,605 us | 16,449 us | 14,764 us | +49.6% | +66.7% |
| bs=10 sw=10 sl=64 | p99 | 24,605 us | 20,911 us | 17,870 us | +17.7% | +37.7% |
| bs=100 sw=10 sl=64 | throughput | 1,140 tuples/sec | 900.44 tuples/sec | 1,084 tuples/sec | +26.6% | +5.2% |
| bs=100 sw=10 sl=64 | MB/s | 0.696 MB/s | 0.55 MB/s | 0.662 MB/s | +26.6% | +5.2% |
| bs=100 sw=10 sl=64 | p50 | 83,662 us | 111,025 us | 94,616 us | -24.6% | -11.6% |
| bs=100 sw=10 sl=64 | p95 | 117,153 us | 116,569 us | 100,981 us | +0.5% | +16.0% |
| bs=100 sw=10 sl=64 | p99 | 117,153 us | 130,664 us | 108,141 us | -10.3% | +8.3% |
| bs=1000 sw=10 sl=64 | throughput | 1,331 tuples/sec | 922.9 tuples/sec | 1,112 tuples/sec | +44.2% | +19.7% |
| bs=1000 sw=10 sl=64 | MB/s | 0.813 MB/s | 0.563 MB/s | 0.679 MB/s | +44.3% | +19.8% |
| bs=1000 sw=10 sl=64 | p50 | 738,599 us | 1,080,907 us | 930,623 us | -31.7% | -20.6% |
| bs=1000 sw=10 sl=64 | p95 | 835,408 us | 1,129,687 us | 974,308 us | -26.0% | -14.3% |
| bs=1000 sw=10 sl=64 | p99 | 835,408 us | 1,157,078 us | 1,002,806 us | -27.8% | -16.7% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,365.89,200,128000,547,0.334,18443.57,24605.44,24605.44
1,100,10,64,20,1754.50,2000,1280000,1140,0.696,83662.29,117152.89,117152.89
2,1000,10,64,20,15020.89,20000,12800000,1331,0.813,738598.98,835408.29,835408.29
Contributor
Author
|
/request-review @mengw15 |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
yangzhang75
force-pushed
the
formview-pr2
branch
from
August 30, 2026 08:31
f4b0160 to
2d221bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Let the backend remember, per workflow, whether it is offered as a Form View, and expose turning that on/off. Backend + DB only; no UI or form logic.
workflow.is_form_view BOOLEAN NOT NULL DEFAULT false(sql/updates/43.sql,changelog.xml,texera_ddl.sql).PUT /enable-form-view/{wid}and/disable-form-view/{wid}, guarded by write access. They update only that column — never rewriting content or bumping the modified time. A plain save preserves the stored value; a duplicate and a hub-clone both inherit it.UnifiedResourceSchemaandWorkflowSearchQueryBuilderinclude the flag in listing/search;WorkflowVersionResourcecarries it across versions;retrieveWorkflow/retrievePublicWorkflowreport it.Naming note vs the issue: the flag is
is_form_view(notis_parameterized) and the endpoints areenable/disable-form-view, per the Form View rename; the migration is43.sqlbecause42.sqlwas already taken on main.Any related issues, documentation, discussions?
Closes #8014. Part of the Form View parent issue #8011; builds on the feature flag from #8013.
How was this PR tested?
WorkflowResourceSpec— 9 new cases covering: enable/disable toggle, rejection without write access, survival across a plain save, inheritance by bothduplicateWorkflowandcloneWorkflow, reporting by both retrieve paths, andformBindingpreserved on disable. Full suite 78/78 green. Compiled and run against an ephemeral Postgres so jOOQ regenerated theis_form_viewcolumn.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Code.