Skip to content

fix(frontend, amber): source filter owners per resource kind and apply them to datasets - #8060

Merged
aicam merged 1 commit into
apache:mainfrom
tanishqgandhi1908:fix/filters-per-resource-owners
Aug 28, 2026
Merged

fix(frontend, amber): source filter owners per resource kind and apply them to datasets#8060
aicam merged 1 commit into
apache:mainfrom
tanishqgandhi1908:fix/filters-per-resource-owners

Conversation

@tanishqgandhi1908

@tanishqgandhi1908 tanishqgandhi1908 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

The Owner filter on the Datasets pages was broken on both sides:

  1. Wrong list. <texera-filters> always read its Owner and ID dropdowns from WorkflowPersistService, so Datasets listed workflow owners and offered a workflow-ID filter.
  2. No effect. VersionedResourceSearchQueryBuilder applied the date, id and full-text filters but dropped params.owners, so selecting an owner changed nothing.
Before:  Datasets -> filters -> workflowPersistService.retrieveOwners()  -> workflow owners
         owner=<email> -> VersionedResourceSearchQueryBuilder            -> ignored

After:   Datasets -> filters -> datasetService.retrieveOwners()          -> dataset owners
         owner=<email> -> VersionedResourceSearchQueryBuilder            -> USER.EMAIL predicate

Before -
Screenshot 2026-08-27 at 3 36 49 PM

After -
Screenshot 2026-08-27 at 4 41 05 PM

  • filters.component.ts gains @Input() entityType, defaulting to Workflow, so the Workflows and
    unified search pages are untouched.
  • VersionedResourceSearchQueryBuilder adds the getContainsFilter(params.owners, USER.EMAIL) the
    workflow builder already uses. The USER join was already in the FROM clause.
  • The id dropdown hides where no id endpoint exists. Adding /dataset/user-dataset-ids and
    /model/user-model-ids is left to a follow-up feature.

Any related issues, documentation, discussions?

Closes #8059.

How was this PR tested?

Five new tests in filters.component.spec.ts (owners per kind, ids only for workflows, dropdown
hidden for datasets) and three in DatasetSearchQueryBuilderSpec (one owner renders the predicate,
several OR together but AND with the id filter, none renders nothing).

cd frontend && npx ng test $(grep -rl "FiltersComponent\|DatasetService" src/app | grep "spec.ts$" | sed 's/^/--include /' | tr '\n' ' ')
sbt 'testOnly *DatasetSearchQueryBuilderSpec'

909 frontend tests, 21 backend, all passing. Plus tsc --noEmit, eslint, prettier, scalafmtCheck.

Manual: signed in as a user with a shared dataset plus their own workflow, the Datasets page now
lists only the dataset's owner, ticking it narrows the list, and the id dropdown is gone. Workflows
page unchanged.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code Opus 5

@github-actions github-actions Bot added engine fix frontend Changes related to the frontend GUI labels Aug 27, 2026
@Yicong-Huang Yicong-Huang added the release/v1.2 back porting to release/v1.2 label Aug 27, 2026
@github-actions
github-actions Bot requested a review from xuang7 August 27, 2026 23:47
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Backport auto-label report

This fix: PR was checked against each actively-supported release branch. release/* labels drive the post-merge backport, so add or remove one to change where this fix lands.

Release branch Analysis
release/v1.2 Already labeled — this fix is queued to backport here.

Auto-label run.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @Yicong-Huang, @aglinxinyuan, @mengw15
    You can notify them by mentioning @Yicong-Huang, @aglinxinyuan, @mengw15 in a comment.

@tanishqgandhi1908

Copy link
Copy Markdown
Contributor Author

/request-review @aicam

@github-actions
github-actions Bot requested a review from aicam August 27, 2026 23:50
@aicam
aicam removed the request for review from xuang7 August 27, 2026 23:52
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Benchmark changes need a look

🟢 0 better · 🔴 3 worse · ⚪ 12 noise (<±5%) · 0 without baseline

Compared against main 516087e benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🔴 bs=10 sw=10 sl=64 420 0.256 22,077/34,389/34,389 us 🔴 -6.6% / 🔴 +145.5%
🔴 bs=100 sw=10 sl=64 950 0.58 104,821/131,942/131,942 us 🔴 +5.9% / 🔴 +38.7%
bs=1000 sw=10 sl=64 1,108 0.677 902,927/955,444/955,444 us ⚪ within ±5% / 🔴 -6.6%
Baseline details

Latest main 516087e from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 420 tuples/sec 448 tuples/sec 893.99 tuples/sec -6.3% -53.0%
bs=10 sw=10 sl=64 MB/s 0.256 MB/s 0.274 MB/s 0.546 MB/s -6.6% -53.1%
bs=10 sw=10 sl=64 p50 22,077 us 21,777 us 11,176 us +1.4% +97.5%
bs=10 sw=10 sl=64 p95 34,389 us 33,153 us 14,009 us +3.7% +145.5%
bs=10 sw=10 sl=64 p99 34,389 us 33,153 us 16,898 us +3.7% +103.5%
bs=100 sw=10 sl=64 throughput 950 tuples/sec 973 tuples/sec 1,157 tuples/sec -2.4% -17.9%
bs=100 sw=10 sl=64 MB/s 0.58 MB/s 0.594 MB/s 0.706 MB/s -2.4% -17.9%
bs=100 sw=10 sl=64 p50 104,821 us 99,008 us 88,763 us +5.9% +18.1%
bs=100 sw=10 sl=64 p95 131,942 us 128,228 us 95,096 us +2.9% +38.7%
bs=100 sw=10 sl=64 p99 131,942 us 128,228 us 102,854 us +2.9% +28.3%
bs=1000 sw=10 sl=64 throughput 1,108 tuples/sec 1,115 tuples/sec 1,187 tuples/sec -0.6% -6.6%
bs=1000 sw=10 sl=64 MB/s 0.677 MB/s 0.681 MB/s 0.724 MB/s -0.6% -6.5%
bs=1000 sw=10 sl=64 p50 902,927 us 896,714 us 874,968 us +0.7% +3.2%
bs=1000 sw=10 sl=64 p95 955,444 us 953,588 us 917,815 us +0.2% +4.1%
bs=1000 sw=10 sl=64 p99 955,444 us 953,588 us 949,868 us +0.2% +0.6%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,476.40,200,128000,420,0.256,22076.57,34388.55,34388.55
1,100,10,64,20,2105.65,2000,1280000,950,0.580,104821.23,131941.94,131941.94
2,1000,10,64,20,18043.46,20000,12800000,1108,0.677,902927.01,955443.71,955443.71

@codecov-commenter

codecov-commenter commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.42%. Comparing base (646e460) to head (3646fc3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8060   +/-   ##
=========================================
  Coverage     93.42%   93.42%           
- Complexity     4703     4705    +2     
=========================================
  Files          1180     1180           
  Lines         47766    47780   +14     
  Branches       5321     5325    +4     
=========================================
+ Hits          44623    44639   +16     
  Misses         1699     1699           
+ Partials       1444     1442    -2     
Flag Coverage Δ *Carryforward flag
access-control-service 81.00% <ø> (ø) Carriedforward from 646e460
agent-service 99.32% <ø> (ø) Carriedforward from 646e460
amber 89.59% <100.00%> (+0.01%) ⬆️
computing-unit-managing-service 73.67% <ø> (ø) Carriedforward from 646e460
config-service 86.73% <ø> (ø) Carriedforward from 646e460
file-service 87.46% <ø> (ø) Carriedforward from 646e460
frontend 95.89% <100.00%> (-0.01%) ⬇️
notebook-migration-service 79.31% <ø> (ø) Carriedforward from 646e460
pyamber 97.78% <ø> (ø) Carriedforward from 646e460
workflow-compiling-service 77.19% <ø> (ø) Carriedforward from 646e460

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aicam
aicam enabled auto-merge August 28, 2026 00:19
@aicam
aicam added this pull request to the merge queue Aug 28, 2026
Merged via the queue into apache:main with commit eddec26 Aug 28, 2026
33 of 39 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport PR opened: draft #8061 (#8061) to release/v1.2, assigned to @tanishqgandhi1908 — needs manual work because the cherry-pick conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine fix frontend Changes related to the frontend GUI release/v1.2 back porting to release/v1.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Owner filter is broken on the Datasets page: it lists workflow owners, and selecting one filters nothing

4 participants