fix(frontend, amber): source filter owners per resource kind and apply them to datasets - #8060
Conversation
…y them to datasets
Backport auto-label reportThis
|
Automated Reviewer SuggestionsBased on the
|
|
/request-review @aicam |
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 420 | 0.256 | 22,077/34,389/34,389 us | 🔴 -6.6% / 🔴 +145.5% |
| 🔴 | bs=100 sw=10 sl=64 | 950 | 0.58 | 104,821/131,942/131,942 us | 🔴 +5.9% / 🔴 +38.7% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,108 | 0.677 | 902,927/955,444/955,444 us | ⚪ within ±5% / 🔴 -6.6% |
Baseline details
Latest main 516087e from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 420 tuples/sec | 448 tuples/sec | 893.99 tuples/sec | -6.3% | -53.0% |
| bs=10 sw=10 sl=64 | MB/s | 0.256 MB/s | 0.274 MB/s | 0.546 MB/s | -6.6% | -53.1% |
| bs=10 sw=10 sl=64 | p50 | 22,077 us | 21,777 us | 11,176 us | +1.4% | +97.5% |
| bs=10 sw=10 sl=64 | p95 | 34,389 us | 33,153 us | 14,009 us | +3.7% | +145.5% |
| bs=10 sw=10 sl=64 | p99 | 34,389 us | 33,153 us | 16,898 us | +3.7% | +103.5% |
| bs=100 sw=10 sl=64 | throughput | 950 tuples/sec | 973 tuples/sec | 1,157 tuples/sec | -2.4% | -17.9% |
| bs=100 sw=10 sl=64 | MB/s | 0.58 MB/s | 0.594 MB/s | 0.706 MB/s | -2.4% | -17.9% |
| bs=100 sw=10 sl=64 | p50 | 104,821 us | 99,008 us | 88,763 us | +5.9% | +18.1% |
| bs=100 sw=10 sl=64 | p95 | 131,942 us | 128,228 us | 95,096 us | +2.9% | +38.7% |
| bs=100 sw=10 sl=64 | p99 | 131,942 us | 128,228 us | 102,854 us | +2.9% | +28.3% |
| bs=1000 sw=10 sl=64 | throughput | 1,108 tuples/sec | 1,115 tuples/sec | 1,187 tuples/sec | -0.6% | -6.6% |
| bs=1000 sw=10 sl=64 | MB/s | 0.677 MB/s | 0.681 MB/s | 0.724 MB/s | -0.6% | -6.5% |
| bs=1000 sw=10 sl=64 | p50 | 902,927 us | 896,714 us | 874,968 us | +0.7% | +3.2% |
| bs=1000 sw=10 sl=64 | p95 | 955,444 us | 953,588 us | 917,815 us | +0.2% | +4.1% |
| bs=1000 sw=10 sl=64 | p99 | 955,444 us | 953,588 us | 949,868 us | +0.2% | +0.6% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,476.40,200,128000,420,0.256,22076.57,34388.55,34388.55
1,100,10,64,20,2105.65,2000,1280000,950,0.580,104821.23,131941.94,131941.94
2,1000,10,64,20,18043.46,20000,12800000,1108,0.677,902927.01,955443.71,955443.71
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8060 +/- ##
=========================================
Coverage 93.42% 93.42%
- Complexity 4703 4705 +2
=========================================
Files 1180 1180
Lines 47766 47780 +14
Branches 5321 5325 +4
=========================================
+ Hits 44623 44639 +16
Misses 1699 1699
+ Partials 1444 1442 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Backport PR opened: draft #8061 (#8061) to |
What changes were proposed in this PR?
The Owner filter on the Datasets pages was broken on both sides:
<texera-filters>always read its Owner and ID dropdowns fromWorkflowPersistService, so Datasets listed workflow owners and offered a workflow-ID filter.VersionedResourceSearchQueryBuilderapplied the date, id and full-text filters but droppedparams.owners, so selecting an owner changed nothing.Before -

After -

filters.component.tsgains@Input() entityType, defaulting toWorkflow, so the Workflows andunified search pages are untouched.
VersionedResourceSearchQueryBuilderadds thegetContainsFilter(params.owners, USER.EMAIL)theworkflow builder already uses. The
USERjoin was already in the FROM clause./dataset/user-dataset-idsand/model/user-model-idsis left to a follow-up feature.Any related issues, documentation, discussions?
Closes #8059.
How was this PR tested?
Five new tests in
filters.component.spec.ts(owners per kind, ids only for workflows, dropdownhidden for datasets) and three in
DatasetSearchQueryBuilderSpec(one owner renders the predicate,several OR together but AND with the id filter, none renders nothing).
909 frontend tests, 21 backend, all passing. Plus
tsc --noEmit, eslint, prettier,scalafmtCheck.Manual: signed in as a user with a shared dataset plus their own workflow, the Datasets page now
lists only the dataset's owner, ticking it narrows the list, and the id dropdown is gone. Workflows
page unchanged.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code Opus 5