Skip to content

feat(huggingface): keep the row on an empty petal measurement #8057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kz930 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(huggingface): keep the row on an empty petal measurement #8057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce96458
feat(huggingface): keep the row on an empty petal measurement
kz930 Aug 27, 2026
569b089
Merge branch 'main' into fix/8056-huggingface-iris-empty-cell
kz930 Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...rg/apache/texera/amber/operator/huggingFace/HuggingFaceIrisLogisticRegressionOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,15 @@ class HuggingFaceIrisLogisticRegressionOpDesc extends PythonOperatorDescriptor {
| training_features_stds = [1.72528903, 0.73788937]
| length = tuple_[$petalLengthCmAttribute]
| width = tuple_[$petalWidthCmAttribute]
| # An empty cell arrives as None, which numpy carries as an object the
| # standardization cannot subtract from. Keep the row and leave the
| # prediction empty rather than ending the run over a measurement the
| # model was never given.
| if length is None or width is None:
| tuple_[$predictionClassName] = None
| tuple_[$predictionProbabilityName] = None
| yield tuple_
| return
| features = np.array([[length, width]])
| features = ((features - training_features_means) / training_features_stds)
| features = torch.from_numpy(features).float()
Expand Down
10 changes: 10 additions & 0 deletions ...pache/texera/amber/operator/huggingFace/HuggingFaceIrisLogisticRegressionOpDescSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,16 @@ class HuggingFaceIrisLogisticRegressionOpDescSpec extends AnyFlatSpec with Match
carries(code, "species") shouldBe true
}

// An empty cell reaches the standardization as a None, which numpy cannot
// subtract from, so the row is answered rather than ending the run.
it should "leave the prediction empty when a measurement is missing" in {
val d = configured()
val code = d.generatePythonCode()
code should include("if length is None or width is None:")
code should include("yield tuple_")
code should include("return")
}

"HuggingFaceIrisLogisticRegressionOpDesc.getPhysicalOp" should
"wire an OpExecWithCode python executor carrying the operator's ports" in {
val d = configured()
Expand Down
Loading