fix(frontend): use nested schema required fields - #8003
Open
anthonychengit wants to merge 1 commit into
Open
Conversation
Contributor
Backport auto-label reportThis
|
Contributor
Automated Reviewer SuggestionsBased on the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Nested autofill properties now determine requiredness from the JSON Schema object that directly owns the property.
$refdefinitionDynamicSchemaService.mutatePropertysupplies the owning schema to its match and mutation callbacks.WorkflowCompilingServiceuses that schema'srequiredarray when constructing autofill enums.Any related issues, documentation, discussions?
Closes #7826.
How was this PR tested?
Added positive and negative regression coverage for required and optional nested properties, plus callback coverage for the owning schema.
Result: 2 test files passed; 62 tests passed.
Result: both commands completed successfully.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex was used for implementation and verification assistance. I reviewed the final code and test output before submission.