[WIP][SQL] Fix multi-value UNPIVOT with mixed types - #58810
Open
stevomitric wants to merge 1 commit into
Open
stevomitric wants to merge 1 commit into
stevomitric wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace multi-value UNPIVOT’s COALESCE null filter with independent IS NOT NULL checks joined by OR. Add parser and mixed-type regression tests.
Why are the changes needed?
COALESCE requires a common type, causing valid UNPIVOT queries with unrelated value types, such as DATE and INT, to fail analysis.
Does this PR introduce any user-facing change?
Yes. Multi-value UNPIVOT EXCLUDE NULLS now supports mixed types and removes only rows where every value is null.
How was this patch tested?
New test in the PR.
Was this patch authored or co-authored using generative AI tooling?
Co-Authored-by: OpenAI Codex (GPT-5)