fix: treat NotFound from pod delete in rolling update as success#840
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: treat NotFound from pod delete in rolling update as success#840AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
Signed-off-by: Arunesh Dwivedi <arunesh.dwivedi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeletePodForUpdate deletes the target pod with a UID precondition, but any error from that delete (including Already-NotFound) was logged and surfaced as a PodUpdateError warning. When the pod is already gone - the desired postcondition for this update path - the StatefulSet recreates it, so the NotFound is expected. Now apierrors.IsNotFound is checked and treated as success (normal PodUpdate event) while other delete errors still warn. Added two regression tests (NotFound -> normal event, real error -> warning). Verified with go build, go vet, and the targeted tests pass; the package's Ginkgo/ envtest BeforeSuite is environment-dependent and not related to this change.