Fix license check configuration#1400
Open
moazreyad wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the license-check workflow and Apache RAT configuration.
Changes included:
examples/model_selection/Trails/internal/pg_extension/template/Cargo.pg11.tomlexamples/model_selection/Trails/internal/pg_extension/template/Cargo.pg14.tomlexamples/model_selection/Trails/internal/pg_extension/.cargo/config.tomlCargo.pg11.tomlnow that it has a proper ASF header.0.13to0.18.0.13did not recognize the existinghttps://www.apache.org/licenses/LICENSE-2.0URL indoap/doap_SINGA.rdf.0.18recognizes the HTTPS Apache license URL and resolves the false-positive failure.check-licencetocheck-license.rat.yamltolicense-check.yamlfor clearer naming.Why
The
License-CheckGitHub Actions workflow was failing because Apache RAT reported files with unapproved licenses.Two TOML files were missing ASF headers, and one similar TOML file was excluded from RAT instead of being properly licensed. This PR makes the TOML files consistent
by adding ASF headers and removing the unnecessary exclusion.
The remaining RAT failure was caused by the old RAT
0.13plugin not recognizing the HTTPS Apache License URL already present indoap/doap_SINGA.rdf. UpgradingRAT fixes that issue without changing the DOAP file.
Validation
Ran the same license-check script used by GitHub Actions:
PATH=/opt/apache-maven-3.9.16/bin:$PATH bash -ex tool/rat.sh Result: [INFO] No issues found. [INFO] BUILD SUCCESS