Skip to content

Fix license check configuration#1400

Open
moazreyad wants to merge 1 commit into
apache:masterfrom
moazreyad:fix-license-check
Open

Fix license check configuration#1400
moazreyad wants to merge 1 commit into
apache:masterfrom
moazreyad:fix-license-check

Conversation

@moazreyad

Copy link
Copy Markdown
Contributor

Summary

Fix the license-check workflow and Apache RAT configuration.

Changes included:

  • Add ASF license headers to TOML files that were missing them:
    • examples/model_selection/Trails/internal/pg_extension/template/Cargo.pg11.toml
    • examples/model_selection/Trails/internal/pg_extension/template/Cargo.pg14.toml
    • examples/model_selection/Trails/internal/pg_extension/.cargo/config.toml
  • Remove the RAT exclusion for Cargo.pg11.toml now that it has a proper ASF header.
  • Upgrade Apache RAT Maven plugin from 0.13 to 0.18.
    • RAT 0.13 did not recognize the existing https://www.apache.org/licenses/LICENSE-2.0 URL in doap/doap_SINGA.rdf.
    • RAT 0.18 recognizes the HTTPS Apache license URL and resolves the false-positive failure.
  • Rename the Maven profile from check-licence to check-license.
  • Rename the GitHub Actions workflow file from rat.yaml to license-check.yaml for clearer naming.

Why

The License-Check GitHub Actions workflow was failing because Apache RAT reported files with unapproved licenses.

Two TOML files were missing ASF headers, and one similar TOML file was excluded from RAT instead of being properly licensed. This PR makes the TOML files consistent
by adding ASF headers and removing the unnecessary exclusion.

The remaining RAT failure was caused by the old RAT 0.13 plugin not recognizing the HTTPS Apache License URL already present in doap/doap_SINGA.rdf. Upgrading
RAT fixes that issue without changing the DOAP file.

Validation

Ran the same license-check script used by GitHub Actions:

PATH=/opt/apache-maven-3.9.16/bin:$PATH bash -ex tool/rat.sh

Result:

[INFO] No issues found.
[INFO] BUILD SUCCESS

@moazreyad moazreyad self-assigned this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant