fix: satisfy Rust 1.98 chunks lint - #750
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the workspace Clippy check after Rust 1.98 enabled
chunks_exact_to_as_chunksby default. This failure is already present onmainand also blocks unrelated PRs such as #747 and #749.Changes
chunks_exactcalls withas_chunksin Murmur hashing.Testing
cargo +1.98.0 clippy --locked --all-targets --workspace --features fulltext,vortex -- -D warningscargo +1.98.0 test -p paimon spec::murmur_hash --libcargo +1.98.0 test -p paimon test_raw_vector_score_matrix_matches_scalar_metrics --libcargo +1.98.0 test -p paimon-datafusion --test read_tables hybrid_search_testsas_chunkscompiles with the workspace MSRV, Rust 1.91.0.cargo fmt --all -- --checkgit diff --checkNotes
No public API or behavior changes.