Conversation
…cycleScanState table
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Partial caching can cause persisted lifecycle policies to be skipped after restart or cache eviction.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR switches lifecycle configuration and scan-state tables to partial caching to reduce OM memory usage.
Changes:
- Uses partial-cache initialization for both lifecycle tables.
- Retains persisted lifecycle metadata in RocksDB.
File summaries
| File | Summary |
|---|---|
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java |
Changes lifecycle table caching; lifecycle listing still uses cache-only iteration, creating a critical unresolved issue. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ChenSammi
force-pushed
the
HDDS-16420
branch
from
September 15, 2026 11:56
2a0c88b to
5204a0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use partial cache for OmLifecycleConfiguration and OmLifecycleScanState table, instead of full cache, since the bucket lifecycle configuration evaluation happens by default once a day.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16420
How was this patch tested?