HDDS-15677. Update client side version checks to use isSupportedBy.#10611
Open
errose28 wants to merge 4 commits into
Open
HDDS-15677. Update client side version checks to use isSupportedBy.#10611errose28 wants to merge 4 commits into
isSupportedBy.#10611errose28 wants to merge 4 commits into
Conversation
errose28
added
the
zdu
Contributor
Author
|
Compat test failure isn't related to this PR, despite the suite it occurred in:
|
ayushtkn
approved these changes
Jul 1, 2026
Comment on lines
+297
to
+300
| return node(HddsProtos.NodeType.OM, version); | ||
| } | ||
|
|
||
| private static ServiceInfo node(HddsProtos.NodeType nodeType, OzoneManagerVersion version) { |
Member
There was a problem hiding this comment.
this method is called only by
private static ServiceInfo om(OzoneManagerVersion version) {
maybe we could have implemented there itself rather than having two methods
dombizita
reviewed
Jul 1, 2026
| } | ||
| LOG.trace("Ozone Manager version is {}", version.name()); | ||
| return version; | ||
| LOG.trace("Ozone Manager version is {}", minOMVersion); |
Contributor
There was a problem hiding this comment.
Isn't that missing?
Suggested change
| LOG.trace("Ozone Manager version is {}", minOMVersion); | |
| LOG.trace("Ozone Manager version is {}", minOMVersion.name()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace client side version comparison that was previously using
compareTowith the new and more readableisSupportedBy. No functional change is expected.compareTocannot be removed since it is built into the enum, and it provides correct results so there is no harm other than readability.What is the link to the Apache JIRA
HDDS-15677
How was this patch tested?
New coverage was added for the client side version parsing which was previously missing. These tests were generated by Claude Code and reviewed by me.
Green run on my fork