system/sensortest: Add rows for the voltage, current and power topics. - #3793
Merged
linguini1 merged 2 commits intoSep 20, 2026
Merged
Conversation
The three electrical topics exist and publish, but sensortest rejects their node names before opening them: its table is matched by name and carries each structure's size, so a type without a row is one the tool cannot read at all. All three are a timestamp and a single value, the shape print_valf already handles. Signed-off-by: Justin Hammond <justin@dynam.ac>
Each of the ten print helpers opens with a declaration followed immediately by its printf, which nxstyle reports as an error on every one of them. The file cannot be checked cleanly until they are fixed, so a later change to it starts from a failing run and has to sort its own errors from the existing ones. Whitespace only. git diff -w is empty. Signed-off-by: Justin Hammond <justin@dynam.ac>
cederom
approved these changes
Sep 20, 2026
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @Fishwaldo :-)
cederom
requested review from
acassis,
linguini1,
michallenc,
simbit18 and
xiaoxiang781216
September 20, 2026 11:30
acassis
approved these changes
Sep 20, 2026
xiaoxiang781216
approved these changes
Sep 20, 2026
linguini1
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sensortest matches a node name against a table that carries each type's structure size, so a type with no row is rejected before the node is ever opened:
voltage, current and power publish like any other topic. Add their rows. All three are a timestamp and a single value, the shape
print_valfalready handles.The second commit puts a blank line after the declarations in the ten print helpers.
nxstylereports an error on every one of them, so the file could not be checked cleanly and any change to it had to sort its own errors out of the existing ones. Whitespace only;git diff -wis empty.Impact
sensortest only. No existing type changes behaviour. Three types that could not be read at all now can.
Testing
ESWIN EIC7700 EVB, reading an MPQ8785 regulator and four INA226 rails:
12.03 V x 0.73 A = 8.78 W against the 8.79 W reported, so the values are consistent rather than merely present.
nxstyle system/sensortest/sensortest.cis clean after the second commit.